Skip to content

Conversation

TestOpsCloudchen
Copy link
Contributor

localization

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

localization

Motivation and Context

for chinese

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TestOpsCloudchen !

Can you please sign CLA to get this merged.

<i class="fas fa-language"></i> Page being translated from
English to Chinese. Do you speak Chinese? Help us to translate
it by sending us pull requests!
{{% /notice %}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this header should be removed if the translation is done!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so

@TestOpsCloudchen
Copy link
Contributor Author

you please sign CLA to get this merged.

acked

@TestOpsCloudchen
Copy link
Contributor Author

CLA assistant check
All committers have signed the CLA.

acked

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TestOpsCloudchen !

@harsha509
Copy link
Member

Congratulations on your first contribution @TestOpsCloudchen !

@harsha509 harsha509 merged commit 01ea1d2 into SeleniumHQ:dev Jun 22, 2020
selenium-ci added a commit that referenced this pull request Jun 22, 2020
* Update two_factor_authentication.zh-cn.md

localization

* Update two_factor_authentication.zh-cn.md

remove the notice

Co-authored-by: Sri Harsha <Harsha509@users.noreply.github.com> 01ea1d2
@TestOpsCloudchen TestOpsCloudchen deleted the patch-3 branch June 23, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants